Re: [PATCH v2] Remove --allow-empty from the git-commit synopsis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 7, 2010 at 17:52, Sverre Rabbelier <srabbelier@xxxxxxxxx> wrote:
> Heya,
>
> On Wed, Apr 7, 2010 at 12:28, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote:
>> I'd forgotten how the Git project likes rebasing :)
>
> It's not so much the rebasing, but your patch gets applied manually
> from the mbox (meaning a different timestamp) by Junio (meaning a
> different committer), who adds his S-o-b (meaning a different commit
> message), so yeah, the hash is gonna change ;).

Of course, but in this case the patch had already been pushed by Junio
to the Git repository as 1aadbf, my original commit was 1eb6f8. The
SHA1 wouldn't change when it was cherry-picked to master unless it was
further rewritten.

But in any case referencing the mailing list post instead of the SHA1 is better.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]