On Wed, Apr 7, 2010 at 6:13 PM, Fredrik Kuivinen <frekui@xxxxxxxxx> wrote: > On Wed, Apr 7, 2010 at 17:08, Nicolas Pitre <nico@xxxxxxxxxxx> wrote: >> On Wed, 7 Apr 2010, Fredrik Kuivinen wrote: >>> diff --git a/thread-utils.c b/thread-utils.c >>> index 4f9c829..3c8d817 100644 >>> --- a/thread-utils.c >>> +++ b/thread-utils.c >>> @@ -1,4 +1,5 @@ >>> #include "cache.h" >>> +#include <pthread.h> >> >> This will fail compilation on Windows surely? > > I think it will work. We use "#include <pthread.h>" in builtin/grep.c, > builtin/pack-objects.c, and preload-index.c already. > Still, isn't this REALLY the kind of stuff that usually goes in git-compat-util.h? I'm not asking you to change it, I'm just a bit puzzled that the other pthread-clients did it this way... -- Erik "kusma" Faye-Lund -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html