On Thu, Oct 19, 2006 at 09:11:10PM -0400, Nicolas Pitre wrote: > This patch impose an ordering on REF_DELTA objects that doesn't need to > exist. Say for example that an OFS_DELTA depends on an object which is > a REF_DELTA object. With this patch any pack with the base for that > REF_DELTA stored after the OFS_DELTA object will be broken. I don't see where it imposes any ordering. If we see a complete object it will remain complete. If we find a delta, and we have the base in the current repository it will be expanded to a complete object. When we get a delta that doesn't have a base in the current repository it will remain unresolved and is written out as a delta. So the output pack will always contain fewer deltas as the input. btw. I don't really know what OFS_DELTA and REF_DELTA objects are, I grepped the source and found no references to either. I can only find an OBJ_DELTA. But if any of the deltas depend on an object that is not in the thin pack, the base has to be available in the current repository and as such it will be expanded to a full object, replacing the possibly external delta reference with an internal base object. If the base is not found in the current repository the base has to be another object in the original thin pack so we can write out the delta as is. There is no before or after decision here. We don't look back in the thin pack, and we don't have to look forward either. So I don't understand why your example would break or not depending on if the base object happens to be before or after the OFS_DELTA. > And to really do thin pack fixing properly we really want to just append > missing base objects at the end of the pack which falls in the broken > case above. I guess I'll grep through the mailinglists to try to figure out what these OFS and REF deltas are and why they behave so differently depending on their order in the pack. Jan - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html