On Mon, Apr 05, 2010 at 12:50:11PM +0000, Ævar Arnfjörð Bjarmason wrote: > Thanks for looking at the importer, that'll be very useful when fixing > it. But FWIW that `find` invocation isn't a bug. Perl doesn't have a " > " input field separator so "my @files = `find . -type f`" does the > right thing, unlike in the shell. He calls `find $dir -type f`, without a quotemeta on $dir, which perl will pass to the shell to interpret (and is actually a security issue if I can convince you to try importing my svn repository with directory '; rm -rf /;'). > I'm sorry that I brought snerp-vortex into this at all. It wasn't the > main motivation behind this patch, just the straw that broke the > camel's back. I don't in particular have a problem with --allow-empty-message for casual use. Why anybody would want to use it when they could type the much shorter -mnone, I don't know. But it is long enough that people will have to think about using it, which means the people who do so will probably really want it. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html