Chris Webb <chris@xxxxxxxxxxxx> writes: > In exec_cmd.c and git-instaweb.sh, git hard-codes a default path of > /usr/local/bin:/usr/bin:/bin. Introduce a make variable allowing this to be > overridden by passing defpath to make. A question and an issue. * What's the point of making this configurable, other than "because we can"? * Use of "$(x_SQ)" is about protecting whitespaces and single quotes in the literal from make and shell, but does not have anything to do with protecting things like $foo in that literal from the location $x is eventually embedded in. As long as paths on DEFPATH do not have double quote in it (which would be a sane assumption), the patch to exec_cmd.c would work fine, but I don't know if you need an extra quoting when DEFPATH is used in shell scripts. E.g. DEFPATH=$GIT_EXEC_PATH:/usr/bin would have GIT_EXEC_PATH expanded in mongoose configuration file, but will not be expanded in exec_cmd.c, leading to an inconsistent behaviour. Does this matter? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html