Re: [PATCHv5 4/6] instaweb: add minification awareness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> wrote:
> On Thu, 1 Apr 2010, Mark Rada wrote:
> 
> > This patch will cause git-instaweb to use the minified version of gitweb
> > support files (e.g. CSS and JavaScript) if they were generated.
> 
> I was not sure if git-instaweb should use minified files or not, and
> that is why I didn't add support for this to git-instaweb generation.
> But I forgot that git-instaweb uses gitweb.cgi... which in turn can
> use minified versions of gitweb support files.

It can make distro installation footprints smaller, which would
be appreciated.

> > Without minification awareness, generating the minified version of
> > gitweb's support files will generate a broken instaweb script since the
> > copy of gitweb.cgi will look for gitweb.min.* which will not exist.
> 
> Good catch!
> > 
> > Signed-off-by: Mark Rada <marada@xxxxxxxxxxxx>

Thanks Jakub and Mark,

Acked-by: Eric Wong <normalperson@xxxxxxxx>

-- 
Eric Wong
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]