Jan Stępień <jstepien@xxxxxxxxxxxxxxxxxxxxx> writes:
> This commit adds $show_owner_column configuration variable which allows
> to hide the project list "Owner" column if desired.
>
> @@ -4430,7 +4433,7 @@ sub git_project_list_body {
> }
> print_sort_th('project', $order, 'Project');
> print_sort_th('descr', $order, 'Description');
> - print_sort_th('owner', $order, 'Owner');
> + print_sort_th('owner', $order, 'Owner') if $show_owner_column;
> print_sort_th('age', $order, 'Last Change');
Ugly. Think what you would do if somebody else asks you to allow him to
omit 'Description', or perhaps 'Last Change'.
I would understand if the change was to introduce a configuration variable
of the array type @project_column whose default value is qw(project descr
owner age) that is used to control which columns are shown in what order.
If it is undesirable to allow reordering the columns, the configuration
should at least be %omit_project_column used like this, no?
print_sort_th('project', $order, 'Project')
unless $omit_project_column{'project'};
print_sort_th('descr', $order, 'Description')
unless $omit_project_column{'descr'};
...
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html