Re: [PATCH] remote-curl: Add sanity check for url

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes:

> Previously, `git remote-http foo` and subsquent commands would try to
> work on a HTML page. This patch fixes the bug by making one assumption
> about the URL handled by libcurl: it must contain the string "://"

I may be being slow but I do not see the point of this patch.

I thought that remote-foo is never invoked directly from a command line
with random arguments, and fetch/push frontends make the decision based on
the shape of the "URL" (or whatever data used to reach the remote end)
which helper to run.

I do not think your patch would _break_ anything, but my question is more
about the reason why we would want a duplicated check here.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]