Johannes Sixt <j6t@xxxxxxxx> writes:
> Thanks for your work, but I'm worried that in your version the close()
> call is not before the finish_command (but that's really not _that_
> important in this case).
Are you referring to this part in api-run-command.txt?
This describes the arguments, redirections, and environment of a
command to run in a sub-process.
The caller:
1. allocates and clears (memset(&chld, 0, sizeof(chld));) a
struct child_process variable;
2. initializes the members;
3. calls start_command();
4. processes the data;
5. closes file descriptors (if necessary; see below);
6. calls finish_command().
In "if necessary; see below", I tried to find something to help me judge
why you said "That's really not _that_ important in this case", but I
think I failed. Perhaps we would want a bit more detailed discussion in
the document there?
The patch looks fine. Thanks; will queue this one.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html