Files containing foreign $Id$'s were reported as modified directly
on checkout, which ment that it was difficult to keep a clean working
tree when handling commits with files containing such. convert_to_git()
now takes one more mode parameter for controlling this.
Signed-off-by: Henrik Grubbström <grubba@xxxxxxxxxx>
---
Changed from last time to use enum constant IDENT_MODE_FALSE instead
of a plain zero, as suggested by Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx>.
builtin/apply.c | 3 ++-
builtin/blame.c | 3 ++-
cache.h | 8 +++++++-
combine-diff.c | 3 ++-
convert.c | 24 ++++++++++++++++++++----
diff.c | 3 ++-
sha1_file.c | 3 ++-
t/t0021-conversion.sh | 21 +++++++++++++++++++++
8 files changed, 58 insertions(+), 10 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index 6dbe1d7..19fe436 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -1759,7 +1759,8 @@ static int read_old_data(struct stat *st, const char *path, struct strbuf *buf)
case S_IFREG:
if (strbuf_read_file(buf, path, st->st_size) != st->st_size)
return error("unable to open or read %s", path);
- convert_to_git(path, buf->buf, buf->len, buf, SAFE_CRLF_FALSE);
+ convert_to_git(path, buf->buf, buf->len, buf, SAFE_CRLF_FALSE,
+ IDENT_MODE_FALSE);
return 0;
default:
return -1;
diff --git a/builtin/blame.c b/builtin/blame.c
index 3af045b..4cefaba 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -2050,7 +2050,8 @@ static struct commit *fake_working_tree_commit(const char *path, const char *con
if (strbuf_read(&buf, 0, 0) < 0)
die_errno("failed to read from stdin");
}
- convert_to_git(path, buf.buf, buf.len, &buf, SAFE_CRLF_FALSE);
+ convert_to_git(path, buf.buf, buf.len, &buf, SAFE_CRLF_FALSE,
+ IDENT_MODE_FALSE);
origin->file.ptr = buf.buf;
origin->file.size = buf.len;
pretend_sha1_file(buf.buf, buf.len, OBJ_BLOB, origin->blob_sha1);
diff --git a/cache.h b/cache.h
index 6dcb100..d510a22 100644
--- a/cache.h
+++ b/cache.h
@@ -559,6 +559,11 @@ enum safe_crlf {
SAFE_CRLF_WARN = 2,
};
+enum ident_mode {
+ IDENT_MODE_FALSE = 0,
+ IDENT_MODE_KEEP_FOREIGN = 1,
+};
+
extern enum safe_crlf safe_crlf;
enum branch_track {
@@ -1014,7 +1019,8 @@ extern void trace_argv_printf(const char **argv, const char *format, ...);
/* convert.c */
/* returns 1 if *dst was used */
extern int convert_to_git(const char *path, const char *src, size_t len,
- struct strbuf *dst, enum safe_crlf checksafe);
+ struct strbuf *dst, enum safe_crlf checksafe,
+ enum ident_mode identmode);
extern int convert_to_working_tree(const char *path, const char *src, size_t len, struct strbuf *dst);
/* add */
diff --git a/combine-diff.c b/combine-diff.c
index 6162691..ba37bcc 100644
--- a/combine-diff.c
+++ b/combine-diff.c
@@ -758,7 +758,8 @@ static void show_patch_diff(struct combine_diff_path *elem, int num_parent,
if (is_file) {
struct strbuf buf = STRBUF_INIT;
- if (convert_to_git(elem->path, result, len, &buf, safe_crlf)) {
+ if (convert_to_git(elem->path, result, len, &buf,
+ safe_crlf, IDENT_MODE_FALSE)) {
free(result);
result = strbuf_detach(&buf, &len);
result_size = len;
diff --git a/convert.c b/convert.c
index 5a0b7fb..2726c0c 100644
--- a/convert.c
+++ b/convert.c
@@ -433,9 +433,10 @@ static int count_ident(const char *cp, unsigned long size)
}
static int ident_to_git(const char *path, const char *src, size_t len,
- struct strbuf *buf, int ident)
+ struct strbuf *buf, int ident,
+ enum ident_mode identmode)
{
- char *dst, *dollar;
+ char *dst, *dollar, *spc;
if (!ident || !count_ident(src, len))
return 0;
@@ -462,6 +463,20 @@ static int ident_to_git(const char *path, const char *src, size_t len,
continue;
}
+ if ((identmode == IDENT_MODE_KEEP_FOREIGN) && len > 5) {
+ spc = memchr(src + 4, ' ', dollar - src - 4);
+ if (spc && spc < dollar-1) {
+ /* Foreign id.
+ * Contraction of these is inhibited
+ * during status operations to avoid
+ * all files containing such being
+ * marked as modified on checkout.
+ * cf sha1_file.c:index_mem().
+ */
+ continue;
+ }
+ }
+
memcpy(dst, "Id$", 3);
dst += 3;
len -= dollar + 1 - src;
@@ -593,7 +608,8 @@ static int git_path_check_ident(const char *path, struct git_attr_check *check)
}
int convert_to_git(const char *path, const char *src, size_t len,
- struct strbuf *dst, enum safe_crlf checksafe)
+ struct strbuf *dst, enum safe_crlf checksafe,
+ enum ident_mode identmode)
{
struct git_attr_check check[3];
int crlf = CRLF_GUESS;
@@ -620,7 +636,7 @@ int convert_to_git(const char *path, const char *src, size_t len,
src = dst->buf;
len = dst->len;
}
- return ret | ident_to_git(path, src, len, dst, ident);
+ return ret | ident_to_git(path, src, len, dst, ident, identmode);
}
int convert_to_working_tree(const char *path, const char *src, size_t len, struct strbuf *dst)
diff --git a/diff.c b/diff.c
index f5d93e9..9ae688b 100644
--- a/diff.c
+++ b/diff.c
@@ -2113,7 +2113,8 @@ int diff_populate_filespec(struct diff_filespec *s, int size_only)
/*
* Convert from working tree format to canonical git format
*/
- if (convert_to_git(s->path, s->data, s->size, &buf, safe_crlf)) {
+ if (convert_to_git(s->path, s->data, s->size, &buf,
+ safe_crlf, IDENT_MODE_FALSE)) {
size_t size = 0;
munmap(s->data, s->size);
s->should_munmap = 0;
diff --git a/sha1_file.c b/sha1_file.c
index 96c69cc..b7114fc 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -2417,7 +2417,8 @@ static int index_mem(unsigned char *sha1, void *buf, size_t size,
if ((type == OBJ_BLOB) && path) {
struct strbuf nbuf = STRBUF_INIT;
if (convert_to_git(path, buf, size, &nbuf,
- write_object ? safe_crlf : SAFE_CRLF_FALSE)) {
+ write_object ? safe_crlf : SAFE_CRLF_FALSE,
+ write_object ? IDENT_MODE_FALSE : IDENT_MODE_KEEP_FOREIGN)) {
buf = strbuf_detach(&nbuf, &size);
re_allocated = 1;
}
diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh
index 828e35b..f695581 100755
--- a/t/t0021-conversion.sh
+++ b/t/t0021-conversion.sh
@@ -93,4 +93,25 @@ test_expect_success expanded_in_repo '
cmp expanded-keywords expected-output
'
+# Check that files containing keywords with proper markup aren't marked
+# as modified on checkout.
+test_expect_success keywords_not_modified '
+ {
+ echo "File with foreign keywords"
+ echo "\$Id\$"
+ echo "\$Id: NoTerminatingSymbol"
+ echo "\$Id: Foreign Commit With Spaces $"
+ echo "\$Id: NoTerminatingSymbolAtEOF"
+ } > expanded-keywords2 &&
+
+ git add expanded-keywords2 &&
+ git commit -m "File with keywords expanded" &&
+
+ echo "expanded-keywords2 ident" >> .gitattributes &&
+
+ rm -f expanded-keywords2 &&
+ git checkout -- expanded-keywords2 &&
+ test "x`git status --porcelain -- expanded-keywords2`" = x
+'
+
test_done
--
1.6.4.122.g6ffd7
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html