Chris Webb <chris@xxxxxxxxxxxx> writes:
> If a CRAM-MD5 challenge-response is used to authenticate to the IMAP server,
> git imap-send shouldn't warn about the password being sent in the clear.
>
> Signed-off-by: Chris Webb <chris@xxxxxxxxxxxx>
> ---
Makes sense. Thanks.
> imap-send.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/imap-send.c b/imap-send.c
> index aeb2985..7107923 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1226,9 +1226,6 @@ static struct store *imap_open_store(struct imap_server_conf *srvc)
> fprintf(stderr, "Skipping account %s@%s, server forbids LOGIN\n", srvc->user, srvc->host);
> goto bail;
> }
> - if (!imap->buf.sock.ssl)
> - imap_warn("*** IMAP Warning *** Password is being "
> - "sent in the clear\n");
>
> if (srvc->auth_method) {
> struct imap_cmd_cb cb;
> @@ -1253,6 +1250,9 @@ static struct store *imap_open_store(struct imap_server_conf *srvc)
> goto bail;
> }
> } else {
> + if (!imap->buf.sock.ssl)
> + imap_warn("*** IMAP Warning *** Password is being "
> + "sent in the clear\n");
> if (imap_exec(ctx, NULL, "LOGIN \"%s\" \"%s\"", srvc->user, srvc->pass) != RESP_OK) {
> fprintf(stderr, "IMAP error: LOGIN failed\n");
> goto bail;
> --
> 1.7.0.1
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html