On Fri, 26 Mar 2010, Shawn O. Pearce wrote: > "Mike.lifeguard" <mike.lifeguard@xxxxxxxxx> wrote: > > On 10-03-26 08:56 PM, Avery Pennarun wrote: > > > The problem is that everything in git works perfectly with these > > > invalid file modes *except* fsck, and there's rarely a need to run > > > fsck, so this problem can hide for a long time. > > > > So, does the error matter or not? If it doesn't matter, then shouldn't > > Jgit stop whining? If it does, then whatever-it-is needs to be fixed. > > Its less harmful than other types of corruption. But its quite > wrong from a format perspective. The hash of the tree differs even > though there is no semantic difference in the tree content. > > Given that GitHub has blessed the world with this corruption, > we may need to modify JGit to accept it. Should we? This is going to screw up pack v4 (yes, someday I'll have the time to make it real). Nicolas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html