On Thu, Mar 25, 2010 at 12:38 AM, Johannes Sixt <j.sixt@xxxxxxxxxxxxx> wrote: > Am 3/25/2010 7:07, schrieb Chris Packham: >> Signed-off-by: Chris Packham <judge.packham@xxxxxxxxx> > > Your patches violate whitespace rules. Use 'git show --check' to see the > questionable lines. > Will do. BTW theres no mention of --check in git show --help, but one itch at a time. >> --- >> I wasn't sure about the test numbering so I just grabbed the highest one. Still >> need to add tests for the deletion use case. > > According to t/README, t1* would be a suitable category, perhaps t1430. > >> t/t9800-git-alternate.sh | 95 ++++++++++++++++++++++++++++++++++++++++++++++ > > "git" in the name is redundant > Is t1430-alternate-cmd.sh OK with everyone? >> +test_expect_success \ >> + 'Setup for rest of the test' ' > > The modern style for test headers is > [snip] Will incorporate in next update >> +#rm -rf A B C D base >> \ No newline at end of file > > test_done > Ah, I knew it would be something simple like that. I guess I should have started by reading t/README. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html