Nicolas Pitre <nico@xxxxxxxxxxx> writes:
> On Wed, 24 Mar 2010, Shawn O. Pearce wrote:
>
>> Nicolas Pitre <nico@xxxxxxxxxxx> wrote:
>> > Note: there was a dubious usage of fd when calling release_pack_memory()
>> > in xmmap() which is now removed.
>> ...
>> > @@ -100,7 +112,7 @@ void *xmmap(void *start, size_t length,
>> > if (ret == MAP_FAILED) {
>> > if (!length)
>> > return NULL;
>> > - release_pack_memory(length, fd);
>> > + try_to_free_routine(length);
>>
>> This isn't dubious! The fd passed here is to prevent the pack
>> release code from closing this fd right before we try to mmap it.
>> Its an actual bug fix that I had to write years ago, check the
>> history of that section of code... :-)
>
> Argh. My bad. I somehow thought that fd was the actual pack to free
> when specified. Let's drop the very last hunk of the patch then.
> xmmap() is certainly not going to be invoked concurrently to the rest of
> sha1_file.c in a separate thread.
>
> Junio: I suppose you don't need me to resend?
Will just drop the last hunk. Thanks, both.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html