Re: git rev-list formatting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 23, 2010 at 1:26 PM, Jeff King <peff@xxxxxxxx> wrote:
> On Tue, Mar 23, 2010 at 07:06:38AM -0400, Eli Barzilay wrote:
>
>> > [...]
>>
>> I've made a copy of the repository at
>>
>>   http://tmp.barzilay.org/testing.git.tgz
>>
>> which shows what I said when I run
>>
>>   git rev-list --pretty="%b" 267d60518
>>   git rev-list --pretty="%b" 84482
>
> The problem is that most of those commits don't _have_ bodies. Remember
> that "%b" is about everything in the commit message after the first
> first paragraph.
>
> Now one might argue that rev-list should still put in the extra newline
> separator in this case. I haven't been paying attention, but hasn't that
> been discussed in another thread recently?
>

If you're thinking of the stuff I've been working on, that's about
multiple commits ending up at the same line with --pretty=oneline, and
not _really_ about unconditionally adding that new-line. But it is
closely related, and it looks like it's the same code that is
responsible for the current behavior. Commit 55246aa is what made then
new-line conditional in the first place.

-- 
Erik "kusma" Faye-Lund
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]