Re: [PATCH] Add a git-completion rpm subpackage to the spec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Excerpts from Todd Zullinger's message of Sun Mar 21 11:51:56 -0400 2010:

Hi Todd,

> The paths haven't changed currently, though I thought I read that
> eventually they'd like to move the default location for completion
> scripts to /usr/share/bash-completion/ (many are already installed
> there, but are symlinked to /etc/bash_completion.d by
> bash-completion packages (in the Fedora/EPEL packages via %triggers
> when the applications they complete are installed).

Should this be taken as:

* Eventually, /etc/bash_completion will source files directly from
  /usr/share/...
OR
* To play nice with the distros, triggers and symlinks are the way to
  go after installing to /usr/share/...?

> I also haven't made time to see what, if any, of the changes we've
> made in the Fedora packages might be worthwhile to integrate into
> the git.git rpm spec file. :/

I just took a look at the spec from 1.7.0.1-1 in rawhide.  Some of the
stuff it includes is Fedora/RHEL specific, but a few items that I
wouldn't mind seeing merged into the stock .spec file are the
splitting of the daemon package with the addition of an xinetd.d/git
file and the emacs support subpackage.

I also like the gitweb sub-package, but it doesn't meet the (site
specific) needs I have for deployment...In general, I think support in
the standard .spec for it is a good thing though.

> simple to source /etc/bash_completion.d/git.  In that light, is
> there a compelling reason not to install the completion by default?

Well, that's a good point.  I think my personal inclination for a
separate package comes from having it separated in OpenCSW.  Most of
the reasons for a separate package there likely don't apply here
though, so maybe it should be part of git-core?  As I said when I sent
the alternate (separate rpm) version, I'm happy with either solution
as long as the completion support is more easily available when I
build rpms in the future.

Thanks
-Ben
-- 
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]