On Mar 21, 2010, at 12:33 AM, Jonathan Nieder wrote: > Hi again, > > Benjamin Meyer wrote: > >> re-checking the other patches I think they are correct in their >> usage. > > Thanks for checking. > >> I ran the matching tests, the rebase ones passed, >> 3903-stash.sh is already failing before my patch and >> t3904-stash-patch.sh continues passing with the patch. Other then >> running the tests in t/ is there anything I should do to verify >> patches? > > Regarding testing: the best thing to do IMHO is to explain in the commit > message what effect the patch will have. Then reviewers (including you) > can read it and try it out to make sure what you say is true. > > The test suite is not very good for checking that a patch does what > it’s meant to do, but that’s okay, since it has a different purpose [1]. > > As an example of what I mean, here is your patch 1/4 again (untested, > though). I didn’t add any tests since it would be kind of hard to > provoke address space exhaustion at just the right moment. [snip] Thanks for the example. I will try to include a more full explanation for my changes in the future so it can be more easily reviewed. -Benjamin Meyer-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html