On Fri, 19 Mar 2010, Michael Witten wrote:
> On Fri, Mar 19, 2010 at 08:08, Jakub Narebski <jnareb@xxxxxxxxx> wrote:
>> This is non-solution to non-problem.
>>
>> First, the user.name and user.email does not need to be name and email
>> from some email account. It might be some "canonical name" and
>> "canonical email".
>
> The vast majority of patches come in through email; the git tools
> expect the user.name and user.email to reflect physical email account
> information.
>
> You would be correct if it were not for the fact that git currently
> conflates identity and current email system.
It is not true. From the git-config(1) manpage, the description (meaning)
of user.name and user.email is:
user.email::
Your email address to be recorded in any newly created commits.
Can be overridden by the 'GIT_AUTHOR_EMAIL', 'GIT_COMMITTER_EMAIL', and
'EMAIL' environment variables. See linkgit:git-commit-tree[1].
user.name::
Your full name to be recorded in any newly created commits.
Can be overridden by the 'GIT_AUTHOR_NAME' and 'GIT_COMMITTER_NAME'
environment variables. See linkgit:git-commit-tree[1].
As you can see there is nothing about email, and physicsl email account.
It is true that git-send-email asks about the "From" email address to
send email from with user.name + user.email as default value...
unless either sendemail.from or --from option is used.
[See also below].
>> Second, there are (I think) two main sources of 'unstability' in
>> (name,email) pairs, namely A) misconfigured git (when fetching/pushing
>> using git itself), B) wrong name in email etc. (when sending patches
>> via email, 80% of patches in Linux kernel case).
>>
>> In the case of misconfigured git (case A) using UUID wouldn't help,
>> and only make it worse (you would have to configure the same UUID on
>> each machine). What would help here is for git to be more strict and
>> perhaps forbid (some of) autogenerated names and emails.
>
> The uuid string would be typed pretty much only during configuration;
> from there, it's basically just handled by the git tools. Hence, the
> uuid can indeed suffer from typos, but the name/email pair can suffer
> from not only typos but also real life name changing and email account
> switching.
You do not need (in theory at least) to change user.name nor user.email
with real life name changing (like marriage or adoption) and email
account switching.
[...]
>> In the case of sending patches via email, you can use in-body 'From:'
>> to provide (name,email) part that is different than account used to
>> send email.
>
> That's a good solution that I've considered, except for 2 reasons:
>
> * It involves much more opportunities for typos and/or the
> configuration of a non-git tool for a git-specific purpose.
>
> * Many if not most email services will refuse to send messages
> with forged/spoofed email addresses.
Actually git-send-email would automatically add in-body "From:" header
if it is different from the "From:" address for email, and git-am would
automatically prefer in-body "From:" over sender (in-header "From:")
for authorship information.
Sender can be different from author of the patch, there is no problem
with that.
What git can improve here (and perhaps already does it) is handling of
non-ASCII characters in name (e.g. when commit message does not contain
non US-ASCII letters, but user.name does). Perhaps it got corrected
(improved) already.
P.S. Backward compatibility (older git-am) would probably require
UUID in the form of canonical name+email, and use of in-body "From:"
header to pass this UUID when sending patches.
>> In the case of UUID you would need the same: some way to
>> provide UUID in patch (in email).
>
> Yes, but that's automated by tools like git's format-patch. Not using
> something like format-patch or some other git interface is an
> 'out-of-band' communication and that author has essentially chosen not
> to care about his identity.
>
> The use of the uuid field and allowing git tools to handle it is just
> a way to give a person who does care about his identity to keep it
> consistent.
git-send-email *already* automatically deals with sender != author.
[...]
>> What could help in both cases is .mailmap being used (perhaps on
>> demand) in more git commands. See Documentation/mailmap.txt
>> or e.g. git-shortlog(1) manpage. It is quite advanced tool for
>> correcting mistakes (it can correct *both* user name, which is
>> most common usage, but also email address).
>
> The disadvantage here is that it centralizes identity management and
> it is more demanding because the name/email pair is quite unstable.
How in-tree .mailmap file (in-tree like .gitignore and .gitattributes)
is *centralized identity management*? It is as distributed as git
repositories are.
On the other hand user.uuid is not distributed; for security reasons
config is not transferred.
[...]
> [...], and with
> some clever encoding some statistics gathering programs could
> (possibly) run more efficiently.
Well, I guess it is statistics that dominates, not id part. Such
tools shoud simply take .mailmap into account (unless they rely on
git for that.).
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html