Am 18.03.2010 20:03, schrieb Shawn O. Pearce:
> Scott Chacon <schacon@xxxxxxxxx> wrote:
>> +static void get_http_user_name()
>> +{
>> + user_name = xstrdup(getpass("Username: "));
>
> Why are we getting the username via a password prompt where echo
> has been disabled? Traditionally a username field is obtained as
> echoed input.
>
> Also, this method shouldn't be named get_*() if its returning void.
> Sounds far to funny. init_http_user_name()? prompt_for_user_name()?
Or inline the one-liner at its single call-site?
René
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html