On Thursday 18 March 2010, Brandon Casey wrote: > From: Brandon Casey <drafnel@xxxxxxxxx> > > > Signed-off-by: Brandon Casey <casey@xxxxxxxxxxxxxxx> > --- > > > Heh, I guess it's ok to call 'return' in a function returning > void, but it shouldn't be passed an argument. :) > > -brandon > > > notes.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/notes.c b/notes.c > index a4f9926..07941b7 100644 > --- a/notes.c > +++ b/notes.c > @@ -893,7 +893,7 @@ void remove_note(struct notes_tree *t, const > unsigned char *object_sha1) assert(t->initialized); > hashcpy(l.key_sha1, object_sha1); > hashclr(l.val_sha1); > - return note_tree_remove(t, t->root, 0, &l); > + note_tree_remove(t, t->root, 0, &l); > } > > const unsigned char *get_note(struct notes_tree *t, Yes, I noticed this during a recent code review in some related code, but I haven't yet got around to posting a cleanup patch. Acked-by: Johan Herland <johan@xxxxxxxxxxx> ...Johan -- Johan Herland, <johan@xxxxxxxxxxx> www.herland.net -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html