On Sat, Mar 13, 2010 at 5:58 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Mark Lodato <lodatom@xxxxxxxxx> writes: > >> 'git commit-tree' was the last remaining built-in to accept a <tree> but >> not a <tree-ish> (an indirect tree reference through a commit or tag >> object.) > > Historically we deliberately chose not to DWIM things down to tree for > this plumbing command to catch mistakes by Porcelain scripts > (e.g. arguments given in wrong order---the order of commit-tree's > arguments are, eh, unintuitive). > > I do not think that matters much anymore---I do not think this patch > is unsafe. I thought about that, but upon investigation, the _only_ command that doesn't DWIM with respect to object types (<tree> or <commit>) is commit-tree. So, I thought it might make sense to treat this like all the other commands. On the other hand, it may be a good idea to keep this special for safety. If so, then I would just amend the documentation to note that it does not automatically dereference commit or tag objects. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html