On Mon, 15 Mar 2010, Bert Wesarg wrote:
2010/3/15 Henrik Grubbström (Grubba) <grubba@xxxxxxxxxx>:
diff --git a/builtin/apply.c b/builtin/apply.c
index 3af4ae0..25adef8 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
[...]
- convert_to_git(path, buf->buf, buf->len, buf, 0);
+ convert_to_git(path, buf->buf, buf->len, buf, 0, 0);
So this new 0 should be ...
[...]
@@ -556,6 +556,11 @@ enum safe_crlf {
SAFE_CRLF_WARN = 2,
};
+enum ident_mode {
+ IDENT_MODE_FALSE = 0,
... this?
Correct. I followed the style for the preceeding parameter (ie the other
zero), which maps to enum safe_crlf SAFE_CRLF_FALSE. I agree that using
the enum constants here instead of the plain zeros could perhaps be more
readable, but that should be a separate patch.
--
Henrik Grubbström grubba@xxxxxxxxxx
Roxen Internet Software AB grubba@xxxxxxxxx