Brandon Casey <casey@xxxxxxxxxxxxxxx> writes: > test_expect_success 'Setup test repo' ' > setfacl -m d:u::rwx,d:g::---,d:o:---,d:m:rwx $dirs_to_set && > + setfacl -m m:rwx $dirs_to_set && The patch sounds right, but I don't understand the commit message. You set m:rwx, and check_perms_and_acl expects mask::r--, so it's not exactly what check_perms_and_acl checks. My understanding is that you set the mask here to enforce the validity of the ACL, but then you may want to just squash this into [PATCH 2/5]. But again, that's bikeshedding, the patch serie looks right to me. Sorry for not making the test right myself ;-). -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html