Jakub Narebski <jnareb@xxxxxxxxx> writes:
> Nice... although it might be better to use Test::Reporter::Mail::Util
Done.
>> +sub maildomain_net
> Here should be a comment 'following what Test::Reporter does' or
> something like that.
Done.
> Sidenote: alternate soultion would be to write (with one less level of
> indent):
Done all.
>> +sub maildomain_mta
>> +{
>
> Use the same Perl convention that used elsewhere in git-send-email.perl
> (this is usually used Perl style).
>
> +sub maildomain_mta {
The code uses variety of styles. The function below, where the
maildomain*() are related used:
sub send_message
{
Do I keep the "sub....\n{" ?
Jari
-----------------------------------------------------------------------
sub new {
my ($class, $reason) = @_;
return bless \$reason, shift;
--
sub readline {
my $self = shift;
die "Cannot use readline on FakeTerm: $$self";
--
sub usage {
print <<EOT;
git send-email [options] <file | directory | rev-list options >
--
sub format_2822_time {
my ($time) = @_;
my @localtm = localtime($time);
--
sub unique_email_list(@);
sub cleanup_compose_files();
# Variables we fill in automatically, or via prompting:
--
sub do_edit {
if (defined($multiedit) && !$multiedit) {
map {
--
sub chain_reply_to {
if (defined $chain_reply_to &&
$chain_reply_to eq $not_set_by_user) {
--
sub signal_handler {
# Make text normal
--
sub read_config {
my ($prefix) = @_;
--
sub parse_address_line {
if ($have_mail_address) {
return map { $_->format } Mail::Address->parse($_[0]);
--
sub split_addrs {
return quotewords('\s*,\s*', 1, @_);
}
--
sub check_file_rev_conflict($) {
return unless $repo;
my $f = shift;
--
sub get_patch_subject($) {
my $fn = shift;
open (my $fh, '<', $fn);
--
sub ask {
my ($prompt, %arg) = @_;
my $valid_re = $arg{valid_re};
--
sub expand_aliases {
return map { expand_one_alias($_) } @_;
}
--
sub expand_one_alias {
my $alias = shift;
if ($EXPANDED_ALIASES{$alias}) {
--
sub extract_valid_address {
my $address = shift;
my $local_part_regexp = '[^<>"\s@]+';
--
sub make_message_id
{
my $uniq;
--
sub unquote_rfc2047 {
local ($_) = @_;
my $encoding;
--
sub quote_rfc2047 {
local $_ = shift;
my $encoding = shift || 'UTF-8';
--
sub is_rfc2047_quoted {
my $s = shift;
my $token = '[^][()<>@,;:"\/?.= \000-\037\177-\377]+';
--
sub sanitize_address
{
my ($recipient) = @_;
--
sub maildomain_net
{
my $maildomain;
--
sub maildomain_mta
{
my $maildomain;
--
sub maildomain
{
return maildomain_net() || maildomain_mta() || $mail_domain_default;
--
sub send_message
{
my @recipients = unique_email_list(@to);
--
sub cleanup_compose_files() {
unlink($compose_filename, $compose_filename . ".final") if $compose;
}
--
sub unique_email_list(@) {
my %seen;
my @emails;
--
sub validate_patch {
my $fn = shift;
open(my $fh, '<', $fn)
--
sub file_has_nonascii {
my $fn = shift;
open(my $fh, '<', $fn)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html