Junio C Hamano <gitster@xxxxxxxxx> writes:
> if (eval "require Net::Domain") {
Refactored.
>> +{
>> + my $mail_domain_system; # Static variable
>
> This, and ...
Refactored.
>
>> @@ -917,6 +988,8 @@ X-Mailer: git-send-email $gitversion
>> }
>> }
>>
>> + my $maildomain;
>> +
Refactored.
>
>> @@ -962,9 +1040,10 @@ X-Mailer: git-send-email $gitversion
>> }
>>
>> if (!$smtp) {
>> - die "Unable to initialize SMTP properly. Check config. ",
>> + die "Unable to initialize SMTP properly. Check config and use --smtp-debug. ",
>> "VALUES: server=$smtp_server ",
>> "encryption=$smtp_encryption ",
>> + "maildomain=$maildomain",
>
> You said you needed a separate local variable for reporting but that
> doesn't explain why you need three redundant variables. Why can't the
> code look like this?
Refactored.
>
> - once set, ||= ensures that it will we used without needing to
Refactored.
Jari
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html