René Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes: > Am 07.03.2010 13:09, schrieb Nguyễn Thái Ngọc Duy: >> This adds support to show columnized output in the mentioned commands. > > That's a good idea. > > I'm not so sure about the interface, though. Does the task really > warrant adding a new git command? > > If a --column parameter is added, I think it should expose the full > range of options, i.e. fill columns first (ls -C style), fill rows first > (ls -x style) as well as off (ls -1 style) and auto. > > Shouldn't the columnizer use utf8_width() instead of strlen(), like > strbuf_add_wrapped_text() in utf8.c? I agree with all the above. Also I think it should not be able to change the behaviour of these commands so much without being explicitly asked from the command line, especially for plumbing commands like ls-files. IOW, introduction of the configuration variable without thinking things through is a bad idea. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html