On Sun, 2010-03-07 at 21:13 -0800, Junio C Hamano wrote: > Mike Galbraith <efault@xxxxxx> writes: > > > On Sun, 2010-03-07 at 14:29 -0800, Junio C Hamano wrote: > > > >> * "git bisect -- pathspec..." did not diagnose an error condition properly when > >> the simplification with given pathspec made the history empty. > > > > Would that be what led to this somewhat less than perfect tip bisection > > result? > > The bugfix was about the case where there was no change between the bad > and good commit with respect to the given pathspec, so I suspect your case > was irrelevant. Oh, ok. Thanks. > Your case probably was coming from that you originally suspected one of > the commits that touch tools/perf was a culprit, but because that initial > suspicion was wrong, bisection didn't find anything useful. Hm, the successfully bisected and verified culprit was pure tools/perf. marge:..git/linux-2.6 # git show 804b36068eccd8163ccea420c662fb5d1a21b141|grep diff diff --git a/tools/perf/Makefile b/tools/perf/Makefile diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c diff --git a/tools/perf/util/probe-finder.h b/tools/perf/util/probe-finder.h Oh well. Something went wonky.. I'll survive :) -Mike -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html