[PATCH] git-svn: make git svn --version work again

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



by requesting SVN::Core which is needed for the svn version.

Signed-off-by: Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx>
---
In fact, there are a few more places where seemingly a req_svn() is missing.
But the call chains are very confusing. The one seemingly missing in prop_walk()
would be covered by the recursive props test which succeeds, so the caller
must have requested SVN::Core also. I believe this applies to the other places
as well (but not to version()).

Is there any harm done by inserting a superfluous req_svn() in these cases for
good measure?

 git-svn.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/git-svn.perl b/git-svn.perl
index bae7231..1ffb44c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -351,6 +351,7 @@ information.
 }
 
 sub version {
+	::_req_svn();
 	print "git-svn version $VERSION (svn $SVN::Core::VERSION)\n";
 	exit 0;
 }
-- 
1.7.0.1.300.gd855a

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]