Junio C Hamano wrote: > Linus Torvalds <torvalds@xxxxxxxx> writes: > >> There's two things to note about this: >> >> - the libxdiff dependencies are broken, so it's likely that you need to >> do a "make clean; make" to actually see the result of this. > > Eh, stupid-and-obvious like this perhaps. > > --- > > diff --git a/Makefile b/Makefile > index 2c7c338..3fed480 100644 > --- a/Makefile > +++ b/Makefile > @@ -237,6 +237,7 @@ PYMODULES = \ > > LIB_FILE=libgit.a > XDIFF_LIB=xdiff/lib.a > +$(XDIFF_LIB): $(wildcard xdiff/*.[ch]) To combine your more succinct style with my previous patch, its the link between the .o's and the .h's thats missing. $(XDIFF_OBJS): $(wildcard xdiff/*.h) -apw - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html