Re: [PATCH 1/5] Allow explicit ANSI codes for colors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 26, 2010 at 11:57:46PM -0500, Mark Lodato wrote:

> Allow explicit ANSI codes to be used in configuration options expecting
> a color.  The form is "[...m", where "..." are characters in the ASCII
> range 0x30 to 0x3f.  This allows users to specify more complex colors
> (generically, SGR attributes) than our color language allows.  For
> example, to get blinking, bold, underlined, italic, red text,
> use "[5;1;4;3;31m".

I am not against this patch if it gets us some flexibility that is not
otherwise easy to attain, but wouldn't it be more user friendly for us
to support "red blink bold ul italic"? AFAICT, the only things standing
the way of that are:

  - we don't support the italic attribute yet (are there are a lot of
    others that we are missing?)

  - the parser in color_parse_mem already understands how to parse
    multiple attributes, but it just complains after the first one

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]