Frank Li <lznuaa@xxxxxxxxx> writes:
> +if (! exists $ENV{GIT_ASKPASS}) {
> + if (exists $ENV{SSH_ASKPASS}) {
> + $ENV{GIT_ASKPASS} = $ENV{SSH_ASKPASS};
> + if ($^O eq 'msys') {
> + $ENV{GIT_ASKPASS} =~ s/\\/\\\\/g;
> + $ENV{GIT_ASKPASS} =~ s/(.*)/"$1"/;
> + }
> + }
> +}
I've seen this code before, and you may not be the best person to answer
this question, but this worries me and puzzles me a bit.
On msys (and nowhere else), SSH_ASKPASS can be used as given by the user
to launch the prompter, but GIT_ASKPASS must be quoted in some funny way.
Why is that? Does this mean they must be given differently by the end
user? In other words, if the end user wants to set GIT_ASKPASS himself,
s/he needs to do this funny quoting, that is different from SSH_ASKPASS.
I also notice that git-gui has support for SSH_ASKPASS (and its own
implementation). Does it have the same quoting issues on msys?
The reason I am asking is because:
(1) if SSH_ASKPASS and GIT_ASKPASS cannot be specified exactly the same
way, then [PATCH 3/3] would probably need a similar quoting magic?
(2) With [PATCH 3/3], with quoting magic if necessary, we wouldn't need
the above hunk, as it has already be done by the "git" potty.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html