Re: [PATCH] git-gui: fix "Explore Working Copy" for Windows again

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, 25 Feb 2010, Heiko Voigt wrote:

> On Thu, Feb 25, 2010 at 01:14:22AM +0100, Markus Heidelberg wrote:
> > It has already been fixed in commit 454efb47 (git-gui (Win): make
> > "Explore Working Copy" more robust, 2009-04-01), but has been broken in
> > commit 21985a11 (git-gui: handle non-standard worktree locations,
> > 2010-01-23) by accidentally replacing too much with a new variable.
> > 
> > The problem can be reproduced when starting git-gui from within a
> > subdirectory. The solution is to convert the path name, explorer.exe is
> > invoked with, to a platform native name.
> > 
> > Signed-off-by: Markus Heidelberg <markus.heidelberg@xxxxxx>
> > ---
> 
> I can confirm that this does fix the issue which is actually also 
> apparent on Windows XP. If no objections occur I would apply this to the 
> devel branch for msysgit.

No objections from my side!

Thanks,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]