Steven Drake <sdrake@xxxxxxxxxx> writes: > On Tue, 16 Feb 2010, Junio C Hamano wrote: > > I was not worried about what your change does. I am worried about > > protecting what the code after your change currently does from future > > changes done by other people while you are not actively watching the > > patches in flight on this list. > > But that can easly be with the patch below. What does that buy us? "future changes" can revert your patch to builtin-log.c easily. I was talking about having tests in the test suite; any "future changes" that breaks the output your series has established would not pass if you specify what the expected output should be there. Of course they can change the test pattern in their patches, but then we will immediately know they are changing the output. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html