Giuseppe Bilotta schrieb:
> - /* remove these from the environment */
You shouldn't remove this comment.
> - const char *env[] = {
> - ALTERNATE_DB_ENVIRONMENT,
> - DB_ENVIRONMENT,
> - GIT_DIR_ENVIRONMENT,
> - GIT_WORK_TREE_ENVIRONMENT,
> - GRAFT_ENVIRONMENT,
> - INDEX_ENVIRONMENT,
> - NO_REPLACE_OBJECTS_ENVIRONMENT,
> - NULL
> - };
> - conn->env = env;
> + conn->env = local_repo_env;
IMO, you should squash this patch and the previous one under the subject
"Move list of repo-local environment variables to a public place", and
that public place could be environment.c instead of a new file cache.c
(the name "cache.c" is definitely wrong).
-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html