Hi,
I have a patch (further down) to this issue but I only tested this on
Windows 7 and my virtual machine (XP) did not like it for some reason (it
created the shortcut but the shortcut did not work). If anyone else can
confirm that this patch actually works we can include it.
Commit 3748b0 git-gui: update shortcut tools to use _gitworktree
from Guiseppe does break the creation of Desktop shortcuts on Windows.
I do not know whether this has worked with any tcl interpreter as it
attempts to execute $_gitworktree as a command.
Here is my fix:
>From 5c22c39d530ffb308826629d974048d30cd32e53 Mon Sep 17 00:00:00 2001
From: Heiko Voigt <hvoigt@xxxxxxxxxx>
Date: Tue, 23 Feb 2010 10:40:14 +0100
Subject: [PATCH 1/2] git-gui: fix usage of _gitworktree when creating shortcut for windows
Signed-off-by: Heiko Voigt <heiko.voigt@xxxxxxx>
---
git-gui/lib/shortcut.tcl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui/lib/shortcut.tcl b/git-gui/lib/shortcut.tcl
index 79c1888..8cad0e2 100644
--- a/git-gui/lib/shortcut.tcl
+++ b/git-gui/lib/shortcut.tcl
@@ -16,7 +16,7 @@ proc do_windows_shortcut {} {
[info nameofexecutable] \
[file normalize $::argv0] \
] \
- [file normalize [$_gitworktree]]
+ [file normalize $_gitworktree]
} err]} {
error_popup [strcat [mc "Cannot write shortcut:"] "\n\n$err"]
}
--
1.7.0.m5.rc2.15.g8ba4c
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html