On Mon, Feb 22, 2010 at 05:08:14AM -0600, Jonathan Nieder wrote: > The OpenSSL SHA-1 routine is about as fast as block-sha1, but linking > to libcrypto slows down the startup of git commands by an appreciable > amount. Use the BLK_SHA1 implementation by default instead. What is your definition of "about as fast"? I benchmarked up to a 20% slow-down a while back: http://article.gmane.org/gmane.comp.version-control.git/126995 Now my complaint then was specifically about removing openssl sha1 support entirely, and I have no problem with setting OPENSSL_SHA1 in my build options, but it does make sense to me that the default should be whatever is fastest for most people. And that means benchmarking blk_sha1 versus the libcrypto linking slow-down on several machines to get actual numbers. Unfortunately, I think we may end up with an apples-to-oranges comparison, as sha1-heavy tasks are affected one way, and scripted many-git-invocation tasks the other way. > Typed “make NO_OPENSSL=1” for the umpteenth time today, but this time > I thought I should something about it. echo 'NO_OPENSSL=1' >config.mak ? > -ifndef NO_OPENSSL > +ifdef OPENSSL_TLS > + BASIC_CFLAGS += -DOPENSSL_TLS > + USE_OPENSSL = Yes > +endif Doesn't this flip the default for using TLS on imap-send? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html