Re: [PATCH] git-gui: fix usage of themed widgets variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20 February 2010 18:01, Heiko Voigt <hvoigt@xxxxxxxxxx> wrote:
> There was one forgotten global so NS was not visible to the method
> which resulted in an error.
>
> Signed-off-by: Heiko Voigt <hvoigt@xxxxxxxxxx>
> ---
>  git-gui/lib/status_bar.tcl |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
> index 5fe3aad..95cb449 100644
> --- a/git-gui/lib/status_bar.tcl
> +++ b/git-gui/lib/status_bar.tcl
> @@ -39,6 +39,7 @@ method _oneline_pack {} {
>  }
>
>  constructor two_line {path} {
> +       global NS
>        set w $path
>        set w_l $w.l
>        set w_c $w.c
> --
> 1.7.0.m5.rc2.13.g7abfa.dirty

The commit message should mention what triggered the error I think -
but this patch is clearly correct.
You can have a

Signed-off-by: Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx>

if you like :)

Pat Thoyts.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]