On Fri, Feb 19, 2010 at 6:39 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Brandon Casey wrote: >>>> On Fri, Feb 19, 2010 at 02:19:47AM -0600, Jonathan Nieder wrote: > >>>>> Hmm, how about /dev/ptmx? (One can check by replacing posix_openpt(...) >>>>> with open("/dev/ptmx", ...) in the test-terminal.c I sent.) >> >> Didn't work on Solaris 7. I applied your series on top of master with the >> change you described. Here's the diff: > [...] >> Here's the result of the terminal test: >> >> # ./test-terminal sh -c "test -t 1" >> # echo $? >> 1 > [...] >> >> And here's the output of t7006-pager: >> *** t7006-pager.sh *** >> * ok 1: set up terminal for tests >> * no usable terminal, so skipping some tests > > Thanks for trying it out. That’s an excellent outcome: it means that > test-terminal compiled without trouble with no makefile magic. It > does seem strange to me that there was no error message. Is > sh -c "test -t 1" false for an ordinary terminal? No, it is true. I also substituted /usr/xpg4/bin/sh and got the same result. -brandon -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html