The strbuf parameter of strbuf_add_wrapped_text() in utf8.c is optional; if it's missing, results are directly written to stdout. By removing this flexibility and converting it to only call "pure" strbuf functions, this series cleans up the code a bit and enables an optimization, which is added in the last patch: [PATCH 1/4] utf8.c: remove print_wrapped_text() [PATCH 2/4] utf8.c: remove print_spaces() [PATCH 3/4] utf8.c: remove strbuf_write() [PATCH 4/4] utf8.c: speculatively assume utf-8 in strbuf_add_wrapped_text() builtin-shortlog.c | 17 ++++++++++++-- utf8.c | 61 +++++++++++++++++++++++---------------------------- utf8.h | 1 - 3 files changed, 42 insertions(+), 37 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html