Matthieu Moy <Matthieu.Moy@xxxxxxx> writes: > In short: if a user wants to share a git repository using POSIX > filesystem ACLs, it seems everything works except pack file creation. > The problem is that we create the file with a mode 0600, i.e. no > permission for group,... Modulo that it is more like "we let mkstemp() to choose whatever file mode", this is a good analysis. I think some versions of glibc used to have mkstemp() that creates 0644 or 0664, meaning that the modes left by various implementations of mkstemp() are different from each other, and also different from what we want. With aef5aed (pack-objects: quickfix for permission modes., 2007-04-22) and b6b32cc (Fix 'quickfix' on pack-objects., 2007-04-22), were attempts to work around that issue. By not using mkstemp() from the platform but having our own would allow us to not even worry about this issue (this can be seen by the removal of a call to umask() in [PATCH 4/4]). I see your patches as a "bite-the-bullet and do the right thing" solution. > The test-case is really weak: ideally, we should have a real test with > several users interacting. But that's hardly scriptable in a portable > way, so the only testcase I added relies on getfacl and "ls -l" to find > out if the result is correct. However, I did some manual testing, and > as far as I can say, Git works very well with ACLs with this patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html