Tay Ray Chuan <rctay89@xxxxxxxxx> writes: > This patch series adds --progress to: > > - git-fetch > - git-pull > - git-push > > I suspect the most contentious issue in this patch series would be the > logic that determines whether progress reporting is done. This is found > in patch 6 for transport.c::transport_set_verbosity(). > > As a guide, I used Jeff's message (gmane#121065). The rules used are as > follows (processing aborts when a rule is satisfied): > > 1. Report progress, if force_progress is 1 (ie. --progress). > 2. Don't report progress, if verbosity < 0 (ie. -q/--quiet). > 3. Report progress if isatty(2) is 1. > > This changes the current implementation such that if both --progress > and --quiet are specified, progress is reported. I don't think this is > a very significant change, but I think it makes sense, since I expect > --progress to be mostly used by script writers or IDE integrators (to > force progress reporting even if stderr is not a terminal). I gave a cursory look and they all looked sensible (except for 1/10 on which I already commented separately). Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html