James Pickens <jepicken@xxxxxxxxx> writes: > I'm not sure how to interpret the "subtle breakage" comment with the > winking smiley. Do you mean that preload_index in 1.7.0 is not well tested > and may be broken? FWIW, I didn't notice any breakage, but I didn't do > much testing. The new "status" codepath is different from "commit --dry-run" codepath that was used by "git status" in 1.6.6 series. This old codepath has been used extensibly with preloaded index and is continued to be used when you run "git commit" with various options. It is not preload-index that could be subtly broken. However, nobody used the new "status" codepath with preloaded index, and I haven't thought things through if anything we are doing in that codepath is incompatible with preloaded index in some way. By the way, the argument to read_cache_preload() should be s.pathspec, not NULL, I think. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html