On Tue, 16 Feb 2010, Junio C Hamano wrote:
> This needs some test to make sure that it triggers when configuration is
> set, it doesn't when configuration is not set [...]
Done get wat you mean?
> [...] and it doesn't for commands
> in log family when it shouldn't (most notably, format-patch).
Good point, and looking at the code "log.decorate" only has an affect after
cmd_log_init() is called, which is call by cmd_whatchanged(), cmd_show(),
cmd_log_reflog() and cmd_log() so only those command are affected
(notably not format-patch).
However if thats not disirable, we could always add
'whatchanged.decorate', 'show.decorate' and reflog.decorate'.
> > +log.decorate::
> > + Print out the ref names of any commits that are shown by the log
> > + command. If 'short' is specified, the ref name prefixes 'refs/heads/',
> > + 'refs/tags/' and 'refs/remotes/' will not be printed. If 'full' is
> > + specified, the full ref name (including prefix) will be printed.
> > + This is the same as the log commands '--decorate' option.
>
> This should be the same as --decorate option, so it should be possible to
> set it as a boolean true to mean "short", i.e.
>
> [log]
> decorate
> decorate = true
>
> should be treated exactly the same way as
>
> [log]
> decorate = short
I thought about that but did not want start adding git_config_XXX()
functions, but you want to add git_config_maybe_bool() then I would agree
with add your patch on top (and you should do so).
While on the subject of git_config I think die_bad_config() should be an
extern (i.e. decleared in cache.h and a static function) so that it could
be used in git_XXX_config functions for handling error. Something like:
diff --git a/builtin-log.c b/builtin-log.c
index f096eea..a41a7bb 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -264,6 +264,8 @@ static int git_log_config(const char *var, const char *value, void *cb)
decoration_style = DECORATE_FULL_REFS;
else if (!strcmp(value, "short"))
decoration_style = DECORATE_SHORT_REFS;
+ else
+ die_bad_config(var);
return 0;
}
if (!strcmp(var, "log.showroot")) {
--
Steven
UNIX is basically a simple operating system,
but you have to be a genius to understand the simplicity --- dmr
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html