On Sat, Feb 13, 2010 at 06:23:43AM -0500, Jeff King wrote:
> On Sat, Feb 13, 2010 at 12:07:51PM +0100, Björn Gustavsson wrote:
>
> > diff --git a/git-add--interactive.perl b/git-add--interactive.perl
> > index cd43c34..4eb7c7c 100755
> > --- a/git-add--interactive.perl
> > +++ b/git-add--interactive.perl
> > @@ -1439,6 +1439,8 @@ sub patch_update_file {
> > !defined $hunk[$ix]{USE});
> > }
> > }
> > + } continue {
> > + print "\n" x 4, '=' x 72, "\n";
> > }
> >
> > @hunk = coalesce_overlapping_hunks(@hunk);
>
> Wow, I find this terrifically ugly. I guess you don't use
Side note. Even if we did want to do something like this, your
implementation is probably not the right way. It will print the huge
"===" separator even after the last hunk. You would want to keep a
"$shown_any" variable and output the separator before showing a hunk
instead.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html