Re: [PATCH 3/4] git-am: Add command line parameter `--keep-cr` passing it to git-mailsplit.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Also sprach Junio C Hamano am Thu, 11 Feb 2010 at 15:21:32 -0800:
> "Stefan-W. Hahn" <stefan.hahn@xxxxxxxxx> writes:
> 
> > If applying patches with the following command sequence
> >
> >    git format-patch --stdout ... | git am ...
> >
> > in repositories having files with dos and unix line endings
> > git-mailsplit, which is called from git-am must be called with
> > `--keep-cr` parameter since commit c2ca1d79.
> 
> Sorry, I cannot parse this.

What?

> Perhaps you meant to have a comma between "git-am" and "must be"?
> 
> > +e,keep-cr       pass --keep-cr flag to git-mailsplit for mbox format
> 
> This short form -e does not make much sense to me.  Why is it -e, and do
> we even need a short form in the first place?

Just for shortening the commandline.

> or even:
> 
> 	if test -n "$r$k"
>         then
>         	keep_cr=--keep-cr
> 	else
>         	keep_cr=
> 	fi

This one. I will make a patch soon.

Stefan
-- 
Stefan-W. Hahn                          It is easy to make things.
/ mailto:stefan.hahn@xxxxxxxxx /        It is hard to make things simple.			

Please note that according to the German law on data retention,
information on every electronic information exchange with me is
retained for a period of six months.
Bundesgesetzblatt:
http://www.bgblportal.de/BGBL/bgbl1f/bgbl107s3198.pdf
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]