On Tue, Feb 9, 2010 at 8:10 PM, Yasushi SHOJI > In the diff-index case, it, indeed, has RUN_SETUP explicitly > set. however, it does not have NEED_WORK_TREE set. And, this is > correct in the current semantics because diff-index is a tool to > compare the index and the object store. it does not need a work tree. Unless --cached is given, work tree is needed. I'm not saying that diff-index is bug-free. But the bug you described is not relevant to this. > However, diff-index is used in describe which need a work tree if > --dirty is given. That means that diff-index might be called > with --work-tree. Yes. And git-describe calls git-diff-index correctly, i.e. without --cached. >> > In that case, we must change the setup functions signature to >> > allow marking "not interested" or something. >> >> I'm not sure I get your idea. > > Given that in the current form of git, many built-in command is called > by many other built-in commands. It is hard to predict what is needed > and what's not. Plus, --git-dir and --work-tree are options to git > itself not built-in's. So, I thought it might be a good idea to call, > say, setup_work_tree_with_abs_path(), regardless of NEED_WORK_TREE, to > explicitly setup run time environment before any other part of the > code call, say, open_sha1_file. The thing is not every command expect cwd to be moved to top directory. In other words, they don't care about the prefix argument being passed to it. So you would need go go through all commands before doing that. By the way, are you working on a patch for the diff-index bug? -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html