Johannes Sixt schrieb:
> Or did you replace only selected error() and warning() calls by rp_error()
> and rp_warning()?
Actually, you want to send only selected messages to the pusher. For
example, these look like errors on the server side (right?) and should go
to the site administrator:
> if (!is_null_sha1(new_sha1) && !has_sha1_file(new_sha1)) {
> - error("unpack should have generated %s, "
> - "but I can't find it!", sha1_to_hex(new_sha1));
> + rp_error("unpack should have generated %s, "
> + "but I can't find it!", sha1_to_hex(new_sha1));
> return "bad pack";
> }
> if (!old_object || !new_object ||
> old_object->type != OBJ_COMMIT ||
> new_object->type != OBJ_COMMIT) {
> - error("bad sha1 objects for %s", name);
> + rp_error("bad sha1 objects for %s", name);
> return "bad ref";
> }
> old_commit = (struct commit *)old_object;
In particular, your patch does not send errors produced by unpack-objects
or index-pack to the pusher over the sideband, and this is the right thing
to do.
-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html