On Mon, Feb 8, 2010 at 10:55 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Jay Soffian <jaysoffian@xxxxxxxxx> writes:
>
>> - if (lno < top)
>> + if (lno < top || lno < bottom)
>> die("file %s has only %lu lines", path, lno);
>
> Thanks; I think we make sure that "bottom < top" always hold true before
> we reach this point, so checking with bottom alone should suffice, no?
Right, so given "-L 10" at the point of that check:
bottom = 0
top = 10
Whereas given "-L 10,100" at the point of that check:
bottom = 9
top = 100
So the code needs to check both. Previously it made sure neither was
< 1, and swapped bottom/top if they were reversed.
Sorry for the confusion.
j.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html