Re: [PATCH] t9501: Skip testing load if we can't detect it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Feb 6, 2010, at 1:31 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:

Here is my attempt to reword the commit log message from Brian (the "-1" one, squashed into a revert of the one from yesterday, the latter of which I already pushed out). I just added the first paragraph to better justify the reason why we are testing the codepath that would never be exercised
in real life on platforms that lack /proc/loadavg.

Looks good to me.

   Subject: t9501: Re-fix max load test

   Revert the previous attempt to skip this test on platforms where we
currently cannot determine the system load. We want to make sure that the max-load-limit codepath produces results cleanly, when gitweb is updated and becomes capable of reading the load average by some other
   method.

   The code to check for load returns 0 if it doesn't know how to find
   load.  It also checks to see if the current load is higher than the
max load. So to force the script to quit early by setting the maxload
   variable negative which should work for systems where we can detect
   load (which should be a positive number) and systems where we can't
   (where detected load is 0)

   Signed-off-by: Brian Gernhardt <brian@xxxxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]