Re: [PATCH v2 5/6] receive-pack: Wrap status reports inside side-band-64k

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Shawn O. Pearce" <spearce@xxxxxxxxxxx> writes:

> If the client requests the side-band-64k protocol capability we
> now wrap the status report data inside of packets sent to band #1.
> This permits us to later send additional progress or informational
> messages down band #2.
>
> If side-band-64k was enabled, we always send a final flush packet
> to let the client know we are done transmitting.

Two questions.

 - Why does use_sideband, the variable with the same name as a boolean
   variable used by other parts of the system to decide whether we should
   or should not use the sideband communiocation, get a value other than 0
   or 1?  What is the benefit of using it to keep an actual value?  Does
   the benefit outweigh the confusion factor?

 - What happens if client wants only side-band, not 64k?  This is just
   theoretical and "we don't bother" is a perfectly acceptable answer.  I
   am just curious ;-).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]